Fix crit type limit #156
Merged
Fix crit type limit #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Still attribute 410 is not fixed..
Batfoxkid
approved these changes
Jan 4, 2024
|
The CI doesn't seem to take into account whether build succeeds for all compiled plugins... |
|
Damn, you right. My mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known Bugs:
mod crit type on bossesoverride normal critical(ex. headshot, flare).Fix:
In
CTFGameRules::ApplyOnDamageModifyRules, if damage type hasDMG_CRIT, critType will change to 2(Crit_Full).In FF2R, if
OnTakeDamagelibrary doesn't exist, check damage type is DMG_CRIT. But library exist, only check critType.But most situation need to check damage type. Because critType will be determined in
CTFGameRules::ApplyOnDamageModifyRules.So I added damage type check.
Still attribute 410 is not fixed..
This should fix #138.