Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vu-1075 allow parsing ts files #19

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Vu-1075 allow parsing ts files #19

merged 1 commit into from
Jul 5, 2023

Conversation

thomas-vurvey
Copy link
Contributor

@thomas-vurvey thomas-vurvey commented Jul 4, 2023

CI was already failing previously, misconfiguration.
How is it deployed?

@NoahTheDuke
Copy link
Contributor

NoahTheDuke commented Jul 4, 2023

CI is failing because the package-lock.json was deleted and the github actions yaml wasn't updated to use npm install instead of npm ci.

This is deployed to npm through the batterii group, which i think means if you have write access to the group, you can deploy.

The change you made shouldn't be necessary. When are you consuming un-transpiled typescript? How is require reading it correctly?

@thomas-vurvey
Copy link
Contributor Author

CI is failing because the package-lock.json was deleted and the github actions yaml wasn't updated to use npm install instead of npm ci.

This is deployed to npm through the batterii group, which i think means if you have write access to the group, you can deploy.

The change you made shouldn't be necessary. When are you consuming un-transpiled typescript? How is require reading it correctly?

Its being used in vurvey-api like this:
https://github.com/Batterii/vurvey-api/pull/790#issuecomment-1618825123
Its using different ts loader

@NoahTheDuke
Copy link
Contributor

I no longer work for Batterii so I can't see that merge request. I would recommend adding support for that loader directly to fixture riveter and testing it.

@thomas-vurvey
Copy link
Contributor Author

I no longer work for Batterii so I can't see that merge request. I would recommend adding support for that loader directly to fixture riveter and testing it.

Its too much hustle for now, just needs this simple feature. Ive removed altering previous fn and added a new one with doc

@jroell jroell merged commit 641b010 into master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants