Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review cycle1 #4

Merged
merged 6 commits into from
Oct 28, 2022
Merged

Review cycle1 #4

merged 6 commits into from
Oct 28, 2022

Conversation

BauerMarco
Copy link
Owner

QED_AmplitudeVector has been removed, along with the full_diagonalization and the first_order_coupling options.

Still left to do:

  • Too many qed specific arguments in run_adc...maybe summarize them all to one option dictionary for qed methods
  • Approximate QED-ADC method is checked for as ReferenceState attribute, even though it doesn't affect the ReferenceState

@BauerMarco BauerMarco merged commit 6edf332 into master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BauerMarco @apapapostolou