Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 3.3.2 port #10

Merged
merged 7 commits into from
Oct 3, 2023
Merged

Godot 3.3.2 port #10

merged 7 commits into from
Oct 3, 2023

Conversation

20kdc
Copy link
Contributor

@20kdc 20kdc commented Jul 2, 2021

Gets the game to a completable state on Godot 3.3.2.
There may be bugs that I not yet determined the existence of.
You may want to move this to another branch rather than have it on master.
Note that the Godot 3.3.2 conversion appears to cause default values to be automatically removed, which is responsible for the large amount of deletions.

20kdc added 3 commits July 3, 2021 00:06
…ing animations

The gun would get stuck if you switched colours too fast.
And the boss requires heavy colour-changing...
@20kdc
Copy link
Contributor Author

20kdc commented Jul 2, 2021

I've confirmed game is now completable on this fork.

@20kdc
Copy link
Contributor Author

20kdc commented Oct 13, 2021

Um... hello?

@huangwei4478
Copy link

can compile & run on Godot 3.3.4, so cool!

@20kdc
Copy link
Contributor Author

20kdc commented Nov 8, 2022

...So the fork has been up long enough that someone has forked the fork for some reason.

@20kdc
Copy link
Contributor Author

20kdc commented Sep 30, 2023

...so at this point it's been several Godot minor versions since anything happened with this PR.
Do I update to Godot 3.5? Do I close the PR?
Since it's been, like, nearly a year several years, pinging @Bauxitedev in case this was just lost.

@Bauxitedev
Copy link
Owner

Hi, sorry for ghosting you for so long. Unfortunately, due to the large health/financial impact of getting long COVID in 2020, I can no longer do any kind of open source work.

Do you want write access to the repo? So you can continue the project.

@20kdc
Copy link
Contributor Author

20kdc commented Oct 2, 2023

Uh... I'm not really sure what continuing the project would consist of in this case. This PR simply updates the project a bit so it will work with more modern versions of Godot 3.x. In other branches (not this PR), I tried to make it run on GLES2 for better hardware compatibility, but doing that destroys the lighting, and rebuilding it is... complex.

If it's some sort of legal obligation that prevents you from testing and then hitting the merge button yourself, then I guess you can give me write access for the interim? I doubt anything majorly breaking is going to happen to the 3.x series seeing as 4's out, so not much should need doing in the long term.

@Bauxitedev
Copy link
Owner

Like I said, it's health/financial/time reasons, not legal reasons.

Anyway, I'll go ahead and merge this, thanks.

@Bauxitedev Bauxitedev merged commit 1cf2ffd into Bauxitedev:master Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants