Issue 205: Reset drag states when dropping, even on invalid targets #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #205 : Dropping a dragged object into invalid target breaks the component sidebar
Description
After dropping any element on an invalid target, the component sidebar was staying disabled.
In this PR
resetDrag
function so we can trigger that from different places, and for future improvements keep the logic of resetting the state in one placeBefore, it was just returning from the
drop
even handler when the target was invalid, but thedraggedObject
was still set. Therefore the app still thinks it's in drag mode, and disabling the component sidebar.Testing Notes
Before / After