Fix empty modlist #136
Merged
Fix empty modlist #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionkor
reviewed
Oct 12, 2024
src/Network/Resources.cpp
Outdated
| if (Ret.starts_with("R")) { | ||
| debug("This server is likely outdated, not trying to parse new mod info format"); | ||
| } else { | ||
| auto ModInfos = ModInfo::ParseModInfosFromPacket(Ret); |
There was a problem hiding this comment.
Suggested change
| auto ModInfos = ModInfo::ParseModInfosFromPacket(Ret); | |
| auto [ok, modInfos] = ModInfo::ParseModInfosFromPacket(Ret); |
or something
lionkor
added a commit
to BeamMP/BeamMP-Server
that referenced
this pull request
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the launcher getting confused when the server sends an empty mod list using the new downloading system.
Related server PR: BeamMP/BeamMP-Server#377