Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow semver 2.0 for dev builds #59

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Follow semver 2.0 for dev builds #59

merged 1 commit into from
Oct 25, 2024

Conversation

deathbeam
Copy link
Contributor

@deathbeam deathbeam commented Oct 25, 2024 •
edited
Loading

  • Switch to -build. for dev versions
  • Use builtin dotnet VersionSuffix property instead of custom FlecsVersionSuffix
  • Update README

Reference: https://learn.microsoft.com/en-us/nuget/concepts/package-versioning?tabs=semver20sort#pre-release-versions

@BeanCheeseBurrito
Copy link
Owner

The Version properties needs to be changed to VersionPrefix otherwise the suffix is ignored when packing.

Flecs.NET/src/Flecs.NET/Flecs.NET.csproj

Line 23 in e069012

<Version>4.0.2</Version>

Flecs.NET/src/Flecs.NET.Native/Flecs.NET.Native.csproj

Line 13 in e069012

<Version>4.0.2</Version>

Flecs.NET/src/Flecs.NET.Bindings/Flecs.NET.Bindings.csproj

Line 13 in e069012

<Version>4.0.2</Version>

Switch to -dev. for dev versions

This can be changed to -build. like you mentioned in the Discord if you prefer it.

@deathbeam
Copy link
Contributor Author

Ah, forgot that part, alright updated and also switched to -build

@deathbeam
Follow semver 2.0 for dev builds
3bcd68e 
- Switch to -build.<commit-number> for dev versions
- Use builtin dotnet VersionSuffix property instead of custom FlecsVersionSuffix
- Update README

Reference: https://learn.microsoft.com/en-us/nuget/concepts/package-versioning?tabs=semver20sort#pre-release-versions

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
@BeanCheeseBurrito BeanCheeseBurrito merged commit 25eab70 into BeanCheeseBurrito:main Oct 25, 2024
3 checks passed
@BeanCheeseBurrito
Copy link
Owner

Thanks!

@deathbeam deathbeam deleted the follow-semver2 branch October 25, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deathbeam @BeanCheeseBurrito