Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed calls to function causing deprecation warning where possible #917

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

07pepa
Copy link
Member

@07pepa 07pepa commented Apr 17, 2024

i removed most deprecated warning only left is hiden=True

I also removed some unreachable code

@roman-right
Copy link
Member

Hi @07pepa ,
Could you please check the tests. And there are some conflicts.
Thank you for the PR!

@07pepa 07pepa force-pushed the stop_using_deprecated_features branch 6 times, most recently from dff4c35 to df7c02d Compare May 2, 2024 09:29
@07pepa
Copy link
Member Author

07pepa commented May 2, 2024

@07pepa 07pepa force-pushed the stop_using_deprecated_features branch from df7c02d to 9ad4f24 Compare May 2, 2024 11:36
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jun 17, 2024
@07pepa
Copy link
Member Author

07pepa commented Jun 17, 2024

@roman-right ?

@github-actions github-actions bot removed the Stale label Jun 18, 2024
Copy link
Member

@roman-right roman-right left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dotKokott
Copy link
Contributor

What is still left to do for this to get merged?

@07pepa
Copy link
Member Author

07pepa commented Jul 6, 2024

running ci cd maybe

and @roman-right merging it

@07pepa
Copy link
Member Author

07pepa commented Jul 30, 2024

@dotKokott can be merge RN

@07pepa 07pepa enabled auto-merge (rebase) August 15, 2024 15:19
@07pepa 07pepa disabled auto-merge August 15, 2024 15:19
Copy link

@LawMixer LawMixer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@07pepa 07pepa merged commit 86cbc28 into BeanieODM:main Aug 15, 2024
19 checks passed
@07pepa 07pepa deleted the stop_using_deprecated_features branch August 15, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants