CalcReserve extreme values fix [#25] [#22] #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickkatsios
changed the base branch from
stableswapWF-2
to
s2-upgr-well-remediations
nickkatsios
approved these changes
Aug 15, 2024
Brean0
changed the title
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calcReserveAtRatioSwapandcalcReserveAtRatioLiquidityutilize a LUT to decrease the computation needed to estimate the reserves. When this function is called at extremely high or low values, the function can revert due to overflow or the function not converging.This PR implements the following:
readjusts the max step size when
scaledReserve[j]is updated. This ensures that maxStep size can never be larger than thejreserve.In the case where newton's method overestimates, set high/low price to the new price, which guarantees convergence.
This PR resolves #25 and #22.