-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#126): add tool to generate stories #283
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f275580
to
3ba6932
Compare
1282133
to
23ceacf
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
if i select a component without a
the result is not correct
|
@@ -26,6 +26,7 @@ | |||
"static:serve": "yarn static:build && npx servor out app.html 5000", | |||
"theme:generate-typing": "chakra-cli tokens ./src/theme/theme.ts", | |||
"theme:generate-icons": "svgr --config-file src/components/Icons/svgr.config.js src/components/Icons/svg-sources", | |||
"new:story": "plop story", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have done something like this:
"new:story": "plop story", | |
"generate": "plop", |
Here we create an alias of plop, so we can do the following commands without to define new scripts in package.json:
yarn generate component
yarn generate page
We could have use plop, but I personally don't like yarn plop component
because it doesn't mean anything ^^
Just a thought: I have to be honest, I'm not a huge fan anymore of that PR.
|
Closed for all the reasons above |
This PR is a start for the #126 discussion.
Kapture.2022-09-08.at.23.39.34.mp4