fix: move ftp rule to ruby lang folder

Bearer · Jan 30, 2023 · a35a283 · a35a283
1 parent 0b7157c
commit a35a283
Show file tree

Hide file tree

Showing 14 changed files with 37 additions and 37 deletions.
diff --git a/integration/rules/rules_test.go b/integration/rules/rules_test.go
@@ -74,6 +74,16 @@ func TestRubyLangHttpPostInsecureWithDataDataflow(t *testing.T) {
 	runRulesTest("ruby/lang/http_post_insecure_with_data", "dataflow", t)
 }
 
+func TestRubyLangInsecureFtpSummary(t *testing.T) {
+	t.Parallel()
+	runRulesTest("ruby/lang/insecure_ftp", "summary", t)
+}
+
+func TestRubyLangInsecureFtpDataflow(t *testing.T) {
+	t.Parallel()
+	runRulesTest("ruby/lang/insecure_ftp", "dataflow", t)
+}
+
 func TestRubyLangJwtSummary(t *testing.T) {
 	t.Parallel()
 	runRulesTest("ruby/lang/jwt", "summary", t)
@@ -144,16 +154,6 @@ func TestRubyRailsInsecureCommunicationDataflow(t *testing.T) {
 	runRulesTest("ruby/rails/insecure_communication", "dataflow", t)
 }
 
-func TestRubyRailsInsecureFtpSummary(t *testing.T) {
-	t.Parallel()
-	runRulesTest("ruby/rails/insecure_ftp", "summary", t)
-}
-
-func TestRubyRailsInsecureFtpDataflow(t *testing.T) {
-	t.Parallel()
-	runRulesTest("ruby/rails/insecure_ftp", "dataflow", t)
-}
-
 func TestRubyRailsInsecureSmtpSummary(t *testing.T) {
 	t.Parallel()
 	runRulesTest("ruby/rails/insecure_smtp", "summary", t)

diff --git a/...ettings/rules/ruby/rails/insecure_ftp.yml → ...settings/rules/ruby/lang/insecure_ftp.yml b/...ettings/rules/ruby/rails/insecure_ftp.yml → ...settings/rules/ruby/lang/insecure_ftp.yml
@@ -44,4 +44,4 @@ metadata:
     ## Resources
     - [net-sftp](https://github.com/net-ssh/net-sftp)
   dsr_id: "DSR-2"
-  id: "ruby_rails_insecure_ftp"
+  id: "ruby_lang_insecure_ftp"
diff --git a/...taflow_ruby_rails_insecure_ftp_ftp_new.rb → ...ataflow_ruby_lang_insecure_ftp_ftp_new.rb b/...taflow_ruby_rails_insecure_ftp_ftp_new.rb → ...ataflow_ruby_lang_insecure_ftp_ftp_new.rb
@@ -3,37 +3,37 @@
       detectors:
         - name: ruby
           locations:
-            - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_new.rb
+            - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_new.rb
               line_number: 5
               field_name: email
               object_name: User
     - name: Fullname
       detectors:
         - name: ruby
           locations:
-            - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_new.rb
+            - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_new.rb
               line_number: 5
               field_name: name
               object_name: User
     - name: Passwords
       detectors:
         - name: ruby
           locations:
-            - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_new.rb
+            - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_new.rb
               line_number: 5
               field_name: password
               object_name: User
 risks:
-    - detector_id: ruby_rails_insecure_ftp
+    - detector_id: ruby_lang_insecure_ftp
       locations:
-        - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_new.rb
+        - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_new.rb
           line_number: 8
           parent:
             line_number: 8
             content: Net::FTP.new("ftp.ruby-lang.org")
           content: |
             Net::FTP.new()
-        - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_new.rb
+        - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_new.rb
           line_number: 8
           parent:
             line_number: 8

diff --git a/...aflow_ruby_rails_insecure_ftp_ftp_open.rb → ...taflow_ruby_lang_insecure_ftp_ftp_open.rb b/...aflow_ruby_rails_insecure_ftp_ftp_open.rb → ...taflow_ruby_lang_insecure_ftp_ftp_open.rb
@@ -1,7 +1,7 @@
 risks:
-    - detector_id: ruby_rails_insecure_ftp
+    - detector_id: ruby_lang_insecure_ftp
       locations:
-        - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_open.rb
+        - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_open.rb
           line_number: 3
           parent:
             line_number: 3
@@ -16,7 +16,7 @@
             $<!>Net::FTP.open() do
               $<_>
             end
-        - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_open.rb
+        - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_open.rb
           line_number: 3
           parent:
             line_number: 3
@@ -31,7 +31,7 @@
             $<!>Net::FTP.open() do
               $<_>
             end
-        - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_open.rb
+        - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_open.rb
           line_number: 3
           parent:
             line_number: 3
@@ -46,7 +46,7 @@
             $<!>Net::FTP.open() do
               $<_>
             end
-        - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_open.rb
+        - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_open.rb
           line_number: 3
           parent:
             line_number: 3
@@ -61,7 +61,7 @@
             $<!>Net::FTP.open() do
               $<_>
             end
-        - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_open.rb
+        - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_open.rb
           line_number: 3
           parent:
             line_number: 3

diff --git a/...ls_insecure_ftp_ftp_open_with_datatype.rb → ...ng_insecure_ftp_ftp_open_with_datatype.rb b/...ls_insecure_ftp_ftp_open_with_datatype.rb → ...ng_insecure_ftp_ftp_open_with_datatype.rb
@@ -3,17 +3,17 @@
       detectors:
         - name: ruby
           locations:
-            - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_open_with_datatype.rb
+            - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_open_with_datatype.rb
               line_number: 6
               field_name: email
               object_name: user
 risks:
-    - detector_id: ruby_rails_insecure_ftp
+    - detector_id: ruby_lang_insecure_ftp
       data_types:
         - name: Email Address
           stored: false
           locations:
-            - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_open_with_datatype.rb
+            - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_open_with_datatype.rb
               line_number: 6
               parent:
                 line_number: 3
@@ -34,7 +34,7 @@
         - name: Unique Identifier
           stored: false
           locations:
-            - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_open_with_datatype.rb
+            - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_open_with_datatype.rb
               line_number: 6
               parent:
                 line_number: 3
@@ -51,9 +51,9 @@
                       end
                     end
               object_name: user
-    - detector_id: ruby_rails_insecure_ftp
+    - detector_id: ruby_lang_insecure_ftp
       locations:
-        - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_open_with_datatype.rb
+        - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_open_with_datatype.rb
           line_number: 3
           parent:
             line_number: 3
@@ -73,7 +73,7 @@
             $<!>Net::FTP.open() do
               $<_>
             end
-        - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_open_with_datatype.rb
+        - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_open_with_datatype.rb
           line_number: 3
           parent:
             line_number: 3
@@ -93,7 +93,7 @@
             $<!>Net::FTP.open() do
               $<_>
             end
-        - filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_open_with_datatype.rb
+        - filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_open_with_datatype.rb
           line_number: 3
           parent:
             line_number: 3

diff --git a/..._ruby_rails_insecure_ftp_ok_secure_ftp.rb → ...w_ruby_lang_insecure_ftp_ok_secure_ftp.rb b/..._ruby_rails_insecure_ftp_ok_secure_ftp.rb → ...w_ruby_lang_insecure_ftp_ok_secure_ftp.rb
diff --git a/...ummary_ruby_rails_insecure_ftp_ftp_new.rb → ...summary_ruby_lang_insecure_ftp_ftp_new.rb b/...ummary_ruby_rails_insecure_ftp_ftp_new.rb → ...summary_ruby_lang_insecure_ftp_ftp_new.rb
@@ -1,10 +1,10 @@
 critical:
     - policy_name: ""
       policy_dsrid: DSR-2
-      policy_display_id: ruby_rails_insecure_ftp
+      policy_display_id: ruby_lang_insecure_ftp
       policy_description: Only communicate using SFTP connections.
       line_number: 8
-      filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_new.rb
+      filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_new.rb
       category_groups:
         - PII
       parent_line_number: 8

diff --git a/...mmary_ruby_rails_insecure_ftp_ftp_open.rb → ...ummary_ruby_lang_insecure_ftp_ftp_open.rb b/...mmary_ruby_rails_insecure_ftp_ftp_open.rb → ...ummary_ruby_lang_insecure_ftp_ftp_open.rb
@@ -1,10 +1,10 @@
 low:
     - policy_name: ""
       policy_dsrid: DSR-2
-      policy_display_id: ruby_rails_insecure_ftp
+      policy_display_id: ruby_lang_insecure_ftp
       policy_description: Only communicate using SFTP connections.
       line_number: 3
-      filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_open.rb
+      filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_open.rb
       parent_line_number: 3
       parent_content: |-
         Net::FTP.open("example.com") do |ftp|

diff --git a/...ls_insecure_ftp_ftp_open_with_datatype.rb → ...ng_insecure_ftp_ftp_open_with_datatype.rb b/...ls_insecure_ftp_ftp_open_with_datatype.rb → ...ng_insecure_ftp_ftp_open_with_datatype.rb
@@ -1,10 +1,10 @@
 critical:
     - policy_name: ""
       policy_dsrid: DSR-2
-      policy_display_id: ruby_rails_insecure_ftp
+      policy_display_id: ruby_lang_insecure_ftp
       policy_description: Only communicate using SFTP connections.
       line_number: 3
-      filename: pkg/commands/process/settings/rules/ruby/rails/insecure_ftp/testdata/ftp_open_with_datatype.rb
+      filename: pkg/commands/process/settings/rules/ruby/lang/insecure_ftp/testdata/ftp_open_with_datatype.rb
       category_groups:
         - PII
       parent_line_number: 3

diff --git a/..._ruby_rails_insecure_ftp_ok_secure_ftp.rb → ...y_ruby_lang_insecure_ftp_ok_secure_ftp.rb b/..._ruby_rails_insecure_ftp_ok_secure_ftp.rb → ...y_ruby_lang_insecure_ftp_ok_secure_ftp.rb
diff --git a/...by/rails/insecure_ftp/testdata/ftp_new.rb → ...uby/lang/insecure_ftp/testdata/ftp_new.rb b/...by/rails/insecure_ftp/testdata/ftp_new.rb → ...uby/lang/insecure_ftp/testdata/ftp_new.rb
diff --git a/...y/rails/insecure_ftp/testdata/ftp_open.rb → ...by/lang/insecure_ftp/testdata/ftp_open.rb b/...y/rails/insecure_ftp/testdata/ftp_open.rb → ...by/lang/insecure_ftp/testdata/ftp_open.rb
diff --git a/...re_ftp/testdata/ftp_open_with_datatype.rb → ...re_ftp/testdata/ftp_open_with_datatype.rb b/...re_ftp/testdata/ftp_open_with_datatype.rb → ...re_ftp/testdata/ftp_open_with_datatype.rb
diff --git a/...ls/insecure_ftp/testdata/ok_secure_ftp.rb → ...ng/insecure_ftp/testdata/ok_secure_ftp.rb b/...ls/insecure_ftp/testdata/ok_secure_ftp.rb → ...ng/insecure_ftp/testdata/ok_secure_ftp.rb