fix: reporting of unsupported languages (#1285)

* fix: show correct unsupported languages * fix: sort unsupported languages in output
Bearer · Sep 21, 2023 · def5f02 · def5f02
1 parent a684dcc
commit def5f02
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/internal/report/output/security/security.go b/internal/report/output/security/security.go
@@ -553,20 +553,27 @@ func writeRuleListToString(
 			tbl.AddRow(lang.Name, ruleCount.DefaultRuleCount, ruleCount.CustomRuleCount, len(languages[lang.Name].Files))
 		} else {
 			for _, reportedDependency := range reportedDependencies {
-				if unsupportedLanguages[reportedDependency.DetectorLanguage] {
+				if reportedDependency.DetectorLanguage == lang.Name {
+					unsupportedLanguages[lang.Name] = true
+					tbl.AddRow(lang.Name, 0, 0, len(lang.Files))
 					break
 				}
-				unsupportedLanguages[lang.Name] = true
-				tbl.AddRow(lang.Name, 0, 0, len(languages[lang.Name].Files))
 			}
 		}
 	}
 
 	tbl.Print()
 
 	if len(unsupportedLanguages) > 0 {
-		reportStr.WriteString(fmt.Sprintf("\nWarning: Only partial support is offered for %s.\n", strings.Join(maps.Keys(unsupportedLanguages), ", ")))
-		reportStr.WriteString(color.HiBlackString("For more information, see https://docs.bearer.com/reference/supported-languages\n"))
+		sortedUnsupportedLanguages := maps.Keys(unsupportedLanguages)
+		slices.Sort(sortedUnsupportedLanguages)
+		reportStr.WriteString(fmt.Sprintf(
+			"\nWarning: Only partial support is offered for %s.\n",
+			strings.Join(sortedUnsupportedLanguages, ", "),
+		))
+		reportStr.WriteString(color.HiBlackString(
+			"For more information, see https://docs.bearer.com/reference/supported-languages\n",
+		))
 	}
 
 	return totalRuleCount