Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hashing of scanners in scan id #1186

Merged
merged 1 commit into from
Aug 15, 2023
Merged

fix: hashing of scanners in scan id #1186

merged 1 commit into from
Aug 15, 2023

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Aug 15, 2023

Description

Fixes hashing of scanners (eg. sast, secrets) when building a scan id. The scan id is the key used for caching reports.

Previously, we were including an empty list of scanners each time. This meant that cached reports for one scanner option were being used when a different option was given.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@didroe didroe merged commit 4408f5e into main Aug 15, 2023
5 checks passed
@didroe didroe deleted the fix/scanners-in-scanid branch August 15, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants