Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: report passed not being calculated correctly #1187

Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix: report passed not being calculated correctly #1187

merged 2 commits into from
Aug 15, 2023

Conversation

gotbadger
Copy link
Contributor

@gotbadger gotbadger commented Aug 15, 2023 •
edited
Loading

Description

For formats other than default the security report would not set the exit code correctly. This meant when using rdjson for PR reviews runs would be shown as a pass.

NB: Old behvaiour can be replicated using --exit-code=0.

Related

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@gotbadger gotbadger added the bug Something isn't working label Aug 15, 2023
@gotbadger gotbadger self-assigned this Aug 15, 2023
@gotbadger gotbadger requested a review from didroe August 15, 2023 15:33
@gotbadger gotbadger merged commit f5975b1 into main Aug 15, 2023
5 checks passed
@gotbadger gotbadger deleted the fix/exit-with-correct-code-in-sec-report branch August 15, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didroe didroe didroe approved these changes

Assignees

@gotbadger gotbadger

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gotbadger @didroe