Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move log level and debug flags to General #1257

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Sep 12, 2023

Description

Debug and Log Level flags were Scan flags but we would like to use them in other contexts too (e.g. bearer ignore actions) and so we move them to General flags.

The related docs are also updated.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet mentioned this pull request Sep 12, 2023
4 tasks
Copy link
Contributor

@didroe didroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to call output.Setup in all the commands that want to use these flags.

@elsapet elsapet merged commit 1472058 into main Sep 12, 2023
8 checks passed
@elsapet elsapet deleted the feat/move-log-level-and-debug-flags-to-general branch September 12, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants