Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use local ignores for first scan #1259

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Sep 13, 2023

Description

For initial scan, any local fingerprints in the ignoreFingerprints were being overwritten unintentionally.

Here we rename the local fingerprint var to something unique and return this var when we are not using cloud ignores.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet force-pushed the fix/use-local-ignores-for-first-scan branch from 9f8fb6a to ad0433e Compare September 13, 2023 09:37
@elsapet elsapet force-pushed the fix/use-local-ignores-for-first-scan branch from ad0433e to 679d728 Compare September 13, 2023 09:43
@elsapet elsapet merged commit c7c31f8 into main Sep 13, 2023
9 checks passed
@elsapet elsapet deleted the fix/use-local-ignores-for-first-scan branch September 13, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants