Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore commands no default file value #1266

Merged
merged 1 commit into from
Sep 14, 2023
Merged

fix: ignore commands no default file value #1266

merged 1 commit into from
Sep 14, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Sep 14, 2023

Description

Since we have removed the default ignore-file value, we add a catch for the "" case when writing to the ignore file

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet merged commit b7318ce into main Sep 14, 2023
8 checks passed
@elsapet elsapet deleted the fix/ignore-commands branch September 14, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didroe didroe didroe approved these changes

@cfabianski cfabianski Awaiting requested review from cfabianski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsapet @didroe