Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default ignore file value #1269

Merged
merged 4 commits into from
Sep 15, 2023
Merged

fix: default ignore file value #1269

merged 4 commits into from
Sep 15, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Sep 15, 2023

Description

Updates to the recent changes around --ignore file flag:

  • Add default value back for flag
  • Return actual path to ignore file and use this in console messages
  • Fix migrate and pull commands (which weren't using ignore-file value)
  • In copy, prefer more general "ignore file" (similar to e.g. "config file") to "bearer.ignore file"
  • Update docs accordingly

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

fix: add bearer.ignore as default value

fix: be consistent with ignore file / bearer.ignore file
Copy link
Collaborator

@cfabianski cfabianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@elsapet elsapet merged commit bf59e80 into main Sep 15, 2023
8 checks passed
@elsapet elsapet deleted the fix/default-ignore-file-value branch September 15, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants