Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show warning when unsupported languages are detected #1271

Merged

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Sep 15, 2023

Description

Show warning message when scan detects unsupported language(s)

Closes #1229

Security Report

=====================================

Rules:
https://docs.bearer.com/reference/rules [v0.18.3]

Language    Default Rules  Custom Rules  Files
JavaScript  72             0             3
Python      0              0             35

Warning: Bearer currently offers only partial support for Python. 
For more information, see https://docs.bearer.com/reference/supported-languages

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet requested review from cfabianski, didroe and gotbadger and removed request for cfabianski September 18, 2023 07:50
@elsapet elsapet force-pushed the fix/show-warning-when-unsupported-languages-are-detected branch 2 times, most recently from 3a55848 to 70c7f6d Compare September 18, 2023 14:10
@elsapet elsapet force-pushed the fix/show-warning-when-unsupported-languages-are-detected branch from 70c7f6d to 4d59ba5 Compare September 18, 2023 14:16
@elsapet
Copy link
Contributor Author

elsapet commented Sep 18, 2023

Snapshot changes a bit annoying here - we snapshot the object itself not the JSON / YML so the omitempty is not applied, and we have a lot of blank entries added.

@elsapet elsapet marked this pull request as ready for review September 18, 2023 14:36
Copy link
Collaborator

@cfabianski cfabianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elsapet elsapet merged commit 4f9beb1 into main Sep 19, 2023
8 checks passed
@elsapet elsapet deleted the fix/show-warning-when-unsupported-languages-are-detected branch September 19, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve security scan output when only partial language is supported to not be deceptive to users.
2 participants