Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make engine pluggable #1615

Merged
merged 1 commit into from
May 30, 2024
Merged

chore: make engine pluggable #1615

merged 1 commit into from
May 30, 2024

Conversation

didroe
Copy link
Contributor

@didroe didroe commented May 29, 2024

Description

Makes the engine pluggable. For now, we need to also make all the packages public.

Also:

  • Moves serializable regex type to the regex package
  • Refactors settings to avoid an import cycle

Checklist

If this is your first time contributing please sign the CLA

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.

@didroe didroe force-pushed the chore/make-engine-pluggable branch 5 times, most recently from ea77713 to 380edd9 Compare May 29, 2024 14:37
@didroe didroe marked this pull request as ready for review May 29, 2024 14:43
@didroe didroe requested a review from cfabianski May 29, 2024 14:43
@didroe didroe force-pushed the chore/make-engine-pluggable branch 2 times, most recently from 0b3a04a to bd9c545 Compare May 30, 2024 14:04
@didroe didroe force-pushed the chore/make-engine-pluggable branch from bd9c545 to 3053220 Compare May 30, 2024 14:09
@didroe didroe merged commit edd418f into main May 30, 2024
10 checks passed
@didroe didroe deleted the chore/make-engine-pluggable branch May 30, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants