Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: engine.Close() ordering #1631

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix: engine.Close() ordering #1631

merged 1 commit into from
Jun 10, 2024

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Jun 10, 2024

Description

  • Move engine.Close() to inside scan execution
  • Move happy path os.Exit to inside scan execution (up a level from artifact run)

Checklist

If this is your first time contributing please sign the CLA

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.

@elsapet elsapet requested a review from didroe June 10, 2024 10:12
@elsapet elsapet merged commit f7a1572 into main Jun 10, 2024
8 checks passed
@elsapet elsapet deleted the fix/engine-close-ordering branch June 10, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didroe didroe didroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsapet @didroe