Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add static compilation flag to release #298

Conversation

vjerci
Copy link
Contributor

@vjerci vjerci commented Dec 19, 2022

Description

This pr makes sure that curio runs when c++ toolchain is not installed on system.

Previously we were depending on c++ being installed on the system, since some distributions like centos, debian, and archlinux in some images don't come with c++ installed, Curio failed to run on those.

Checklist

@vjerci vjerci added bug Something isn't working echoes/effort: M labels Dec 19, 2022
@swarmia
Copy link

swarmia bot commented Dec 19, 2022

cfabianski
cfabianski previously approved these changes Dec 19, 2022
@cfabianski
Copy link
Collaborator

#296

Copy link
Contributor

@spdawson spdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at an alternative approach, using nFPM to build Linux packages that declare their dependencies. The static linking approach taken here is probably better, but I'm curious as to what impact this has on the size of the curio binary. It looks like we are currently around 11-12MB; does the static linking dramatically increase this?

@vjerci
Copy link
Contributor Author

vjerci commented Dec 20, 2022

I was looking at an alternative approach, using nFPM to build Linux packages that declare their dependencies. The static linking approach taken here is probably better, but I'm curious as to what impact this has on the size of the curio binary. It looks like we are currently around 11-12MB; does the static linking dramatically increase this?

I've compared the binary itself not the tar (tar is 11-12MB) while binary unpacked is 50-60MB The difference between static and non static is in 0.2MB which isn't signficant.

@vjerci vjerci merged commit 49bffe3 into main Dec 20, 2022
@vjerci vjerci deleted the AMA-3368-fix-missing-c-dependencies-for-certain-linux-distributions branch December 20, 2022 12:00
@spdawson
Copy link
Contributor

Closes #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants