feat: Do not visit Git-ignored files #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spdawson FYI it also scans the |
Yes, I had seen this in the course of my initial investigation — potentially a lot of files being unnecessarily examined 😬 |
spdawson
force-pushed
the
fix/do-not-visit-Git-ignored-files
branch
2 times, most recently
from
5944999
to
7ce4065
Compare
cfabianski
reviewed
Dec 22, 2022
When possible, obtain the list of files to be scanned by means of `git ls-files`. This will automatically exclude files that are covered by the Git ignore file, so that we no longer need even visit these as we walk over the scanned directory tree. Closes #280
Co-authored-by: Cédric Fabianski <cedric@bearer.sh>
spdawson
force-pushed
the
fix/do-not-visit-Git-ignored-files
branch
from
817a781
to
05b6d5d
Compare
cfabianski
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When possible, obtain the list of files to be scanned by means of
git ls-files. This will automatically exclude files that are covered by the Git ignore file, so that we no longer need even visit these as we walk over the scanned directory tree.Note that, as well as excluding Git-ignored files, this also has the benefit that we will no longer process any files under the
.gitdirectory parent; this will typically be thousands of files that we can avoid astaton.Closes #280
Checklist