Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate policy display IDs in policy options #345

Merged
merged 2 commits into from
Jan 9, 2023
Merged

fix: validate policy display IDs in policy options #345

merged 2 commits into from
Jan 9, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Jan 9, 2023 •
edited
Loading

Description

  • When users give policy options (e.g. --skip-policy or --only-policy flags), validate the policy display IDs provided. If they are not correct, raise an error
  • When users give detector options (e.g. --skip-detector or --only-detector flags), validate the detector IDs provided. If they are not correct, raise an error

Screenshot 2023-01-09 at 10 45 28

Screenshot 2023-01-09 at 10 44 50

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet requested a review from vjerci January 9, 2023 08:48
@elsapet elsapet force-pushed the fix/policy-flags-validate-policy-id branch from ae352db to 6645074 Compare January 9, 2023 09:12
@elsapet elsapet merged commit e22109c into main Jan 9, 2023
@elsapet elsapet deleted the fix/policy-flags-validate-policy-id branch January 9, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spdawson spdawson spdawson approved these changes

@vjerci vjerci Awaiting requested review from vjerci

@cfabianski cfabianski Awaiting requested review from cfabianski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--only-policy option doesn't check policy existence
2 participants
@elsapet @spdawson