Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new relic rules and improve sentry rules #471

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Jan 30, 2023

Description

ref: #366

Improve Ruby rules:

  • Adds rules for New Relic
  • Adds additional rules for Sentry

Also improves runtime for integration tests by only loading the specific rule for each test. As part of this, we incidentally fix the following:

  • When using --only-rule, include associated auxiliary rules
  • Make external rules use the same format as default rules

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@didroe didroe force-pushed the feat/third-party-loggers-part1 branch from 13d11d8 to 45e53cb Compare January 30, 2023 16:44
@didroe didroe force-pushed the feat/third-party-loggers-part1 branch from 45e53cb to a66b7c7 Compare January 31, 2023 14:37
@didroe didroe merged commit e4ad4ef into main Jan 31, 2023
@didroe didroe deleted the feat/third-party-loggers-part1 branch January 31, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants