Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up #475

Merged
merged 3 commits into from
Jan 31, 2023
Merged

chore: clean up #475

merged 3 commits into from
Jan 31, 2023

Conversation

cfabianski
Copy link
Collaborator

@cfabianski cfabianski commented Jan 31, 2023

Description

Clean up legacy

  • moved sql create table rules to its own built_in_rules folder (@markmichon will make the documentation simpler as it was a special snowflake until then)
  • remove create view detection (not currently used)
  • moved devise patterns into its own file

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet
Copy link
Contributor

elsapet commented Jan 31, 2023

@cfabianski Thinking about it, I'm wondering if Devise should stay in the rails/ folder - by their description, they are a Rails (rather than Ruby) solution: https://github.com/heartcombo/devise

@cfabianski cfabianski merged commit 5c0b2b8 into main Jan 31, 2023
@cfabianski cfabianski deleted the chore/reoganize-rules branch January 31, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants