Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warn when cached data is used #500

Merged
merged 2 commits into from
Feb 7, 2023
Merged

feat: warn when cached data is used #500

merged 2 commits into from
Feb 7, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Feb 6, 2023 •
edited
Loading

Description

Adds some warning text to the console output, to tell the user when we're using cached data and to prompt them to use --force to force a new scan (if they want)

References #424

Screenshots

Screenshot 2023-02-06 at 16 01 03

Summary

Screenshot 2023-02-06 at 15 59 18

Stats

Screenshot 2023-02-06 at 16 56 23

Privacy

Screenshot 2023-02-06 at 16 56 54

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet requested review from vjerci and cfabianski and removed request for vjerci February 6, 2023 14:28
elsapet
elsapet commented Feb 6, 2023
View reviewed changes
pkg/commands/artifact/run.go Outdated Show resolved Hide resolved
@elsapet elsapet force-pushed the feat/warn-when-cached-data-is-used branch from 11fd44b to 8a525d3 Compare February 6, 2023 14:37
@elsapet elsapet marked this pull request as ready for review February 6, 2023 15:39
@elsapet elsapet requested review from vjerci and didroe February 6, 2023 15:40
@elsapet elsapet force-pushed the feat/warn-when-cached-data-is-used branch from 8a525d3 to ba7aaf6 Compare February 7, 2023 08:20
@elsapet elsapet merged commit cbbf298 into main Feb 7, 2023
@elsapet elsapet deleted the feat/warn-when-cached-data-is-used branch February 7, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

@vjerci vjerci Awaiting requested review from vjerci

@didroe didroe Awaiting requested review from didroe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elsapet @cfabianski @didroe