Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix failure ordering #536

Merged
merged 5 commits into from
Feb 9, 2023
Merged

fix: fix failure ordering #536

merged 5 commits into from
Feb 9, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Feb 9, 2023 •
edited
Loading

Description

The order of failures listed in the summary report was flaky - sometimes it ordered by severity as expected and sometimes not.

We now use an array to enforce the ordering, and have expanded test coverage to catch this flaky case.

We also fix a bug in the warning count - we were counting warnings even if they were not in the given severity
And refactor summary.go to remove further mentions of "policy"

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet merged commit e198667 into main Feb 9, 2023
@elsapet elsapet deleted the fix/fix-failure-ordering branch February 9, 2023 13:19
cfabianski added a commit that referenced this pull request Feb 9, 2023
@cfabianski
Merge remote-tracking branch 'origin/main' into feat/js-rules-for-exc…
ef8710e 
…eptions

* origin/main:
  fix: add mapping for rule severity to category (#538)
  feat: weak encryption javascript (#525)
  feat(summary): improve output and fix some display issues (#537)
  feat: ruby elasticsearch rule (#535)
  fix: fix failure ordering (#536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotbadger gotbadger gotbadger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Warning" level failures should show at bottom of report
2 participants
@elsapet @gotbadger