Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flow and nested detections #572

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Feb 14, 2023

Description

Fixes the following issues identified during testing:

  • Ensure we descend down into unified nodes in Evaluator.TreeHas
  • Replace Implementation.DescendIntoDetectionNode with Detector.NestedDetections - this logic existed to ensure object projections (ie. user.email) don't also detect the original object (ie. all properties on user in this case). This was previously done by avoiding descending into the receiver of a call when evaluating any detections. Instead we now define the object detectors as not allowing nested detections. ie. when a node returns a detection, we do not look for further detections in it's child nodes.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@didroe didroe merged commit 9c79e95 into main Feb 14, 2023
@didroe didroe deleted the fix/flow-and-nested-detections branch February 14, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants