Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix algolia integration test #579

Merged
merged 1 commit into from
Feb 15, 2023
Merged

fix: fix algolia integration test #579

merged 1 commit into from
Feb 15, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Feb 15, 2023 •
edited
Loading

Description

Outdated snapshot found its way to main

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet
Copy link
Contributor Author

elsapet commented Feb 15, 2023

Tests were passing for the original Algolia PR: #574

Working hypothesis is that the PR wasn't up-to-date with main branch and the snapshot failure was not present on the feature branch.

@elsapet elsapet merged commit a93c1c4 into main Feb 15, 2023
@elsapet elsapet deleted the fix/fix-algolia-integration-test branch February 15, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsapet @cfabianski