Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix algolia JS client patterns #586

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix: fix algolia JS client patterns #586

merged 1 commit into from
Feb 16, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Feb 15, 2023

Description

Avoid matching on outdated require syntax. Instead assume standard variable name for module e.g. algoliasearch or algolia.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet requested a review from vjerci February 15, 2023 15:33
@elsapet elsapet merged commit 9309dbc into main Feb 16, 2023
@elsapet elsapet deleted the fix/fix-algolia-js-client-patterns branch February 16, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjerci vjerci vjerci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsapet @vjerci