Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix severity and remove DSW for JS insecure XML ref rule #623

Merged
merged 2 commits into from
Feb 21, 2023
Merged

fix: fix severity and remove DSW for JS insecure XML ref rule #623

merged 2 commits into from
Feb 21, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Feb 20, 2023

Description

  • Remove rogue DSW id (it's copy pasta)
  • Remove other severity marks - this is a presence-only rule

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet force-pushed the fix/fix-insecure-xml-ref-yaml branch from 548daa8 to fee0430 Compare February 21, 2023 08:21
@elsapet elsapet merged commit 0e26e2d into main Feb 21, 2023
@elsapet elsapet deleted the fix/fix-insecure-xml-ref-yaml branch February 21, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotbadger gotbadger gotbadger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsapet @gotbadger