Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ruby rule): add rule for exec using user input #654

Merged
merged 2 commits into from
Feb 27, 2023
Merged

feat(ruby rule): add rule for exec using user input #654

merged 2 commits into from
Feb 27, 2023

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Feb 23, 2023

Description

Adds a Ruby rule for CWE-78, executing OS commands using user input.

Also improves the rule for paths containing user input:

  • Add Shell library
  • Remove overlap with new rule

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@didroe didroe force-pushed the feat/ruby-rule-for-exec-using-user-input branch from ff99a91 to ab582a1 Compare February 23, 2023 15:19
@didroe didroe mentioned this pull request Feb 23, 2023
Closed
21 tasks
@didroe didroe force-pushed the feat/ruby-rule-for-exec-using-user-input branch 2 times, most recently from 07d6c7a to fed05fb Compare February 27, 2023 15:31
@didroe didroe changed the title feat: ruby rule for exec using user input feat (ruby rule): add rule for exec using user input Feb 27, 2023
@didroe didroe changed the title feat (ruby rule): add rule for exec using user input feat(ruby rule): add rule for exec using user input Feb 27, 2023
@didroe didroe force-pushed the feat/ruby-rule-for-exec-using-user-input branch from fed05fb to 59e0cd9 Compare February 27, 2023 16:07
@didroe didroe force-pushed the feat/ruby-rule-for-exec-using-user-input branch from 59e0cd9 to 5d5b065 Compare February 27, 2023 16:15
@didroe didroe merged commit 850933a into main Feb 27, 2023
@didroe didroe deleted the feat/ruby-rule-for-exec-using-user-input branch February 27, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@didroe @cfabianski