fix: fix false positives on req detection #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfabianski
reviewed
Feb 27, 2023
pkg/commands/process/settings/rules/javascript/express/cross_site_scripting/testdata/no_xss.js
Outdated
Show resolved
Hide resolved
elsapet
force-pushed
the
fix/fix-false-positives-on-req-detection
branch
from
8b4764e
to
5987d53
Compare
elsapet
force-pushed
the
fix/fix-false-positives-on-req-detection
branch
from
5987d53
to
717f46c
Compare
cfabianski
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stricter pattern match for detecting problematic request objects. Combined with fix here 0c1ef45 this should address a lot of the false positives seen in battle testing.
Relates to #606
Checklist