Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(javascript rule): hardcoded string support #678

Merged
merged 6 commits into from
Feb 28, 2023

Conversation

vjerci
Copy link
Contributor

@vjerci vjerci commented Feb 27, 2023

Description

This pr adds 2 rules, 1 is for detecting passport usage with hardcoded string
And another one for detecting hardcoded string in config files.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@vjerci vjerci marked this pull request as ready for review February 27, 2023 15:44
@vjerci vjerci changed the title feat: add javascript hardcoded string support feat (javascript rule): hardcoded string support Feb 27, 2023
@vjerci vjerci changed the title feat (javascript rule): hardcoded string support feat(javascript rule): hardcoded string support Feb 27, 2023
vjerci and others added 2 commits February 28, 2023 10:41
…assport_hardcoded_secret.yml

Co-authored-by: elsapet <elizabeth@bearer.sh>
…secret.yml

Co-authored-by: elsapet <elizabeth@bearer.sh>
@vjerci vjerci merged commit 8f94547 into main Feb 28, 2023
@vjerci vjerci deleted the feat/js-passport-hardcoded-string branch February 28, 2023 09:56
@elsapet elsapet mentioned this pull request Feb 28, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants