Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(js rule): enrich js axios rule #686

Merged
merged 1 commit into from
Feb 28, 2023
Merged

feat(js rule): enrich js axios rule #686

merged 1 commit into from
Feb 28, 2023

Conversation

vjerci
Copy link
Contributor

@vjerci vjerci commented Feb 28, 2023

Description

This pr further enriches axios detections

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@vjerci vjerci marked this pull request as ready for review February 28, 2023 11:15
cfabianski
cfabianski approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@cfabianski cfabianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@vjerci vjerci merged commit 11a1ba7 into main Feb 28, 2023
@vjerci vjerci deleted the feat/enrich-http-insecure branch February 28, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsapet elsapet elsapet approved these changes

@cfabianski cfabianski cfabianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vjerci @cfabianski @elsapet