Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(JS rules): add CWE-525 bad caching policy for expressjs JWT not revoked #695

Merged
merged 1 commit into from
Mar 1, 2023
Merged

feat(JS rules): add CWE-525 bad caching policy for expressjs JWT not revoked #695

merged 1 commit into from
Mar 1, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Mar 1, 2023 •
edited
Loading

Description

It's bad caching policy to not revoke JWTs (CWE-525)

Add rule to catch express-jwt JWTs that are not revoked

Relates to #606

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet mentioned this pull request Mar 1, 2023
Closed
26 tasks
@elsapet elsapet changed the title feat(JS rules): add SWE-525 bad caching policy for expressjs JWT not revoked feat(JS rules): add CWE-525 bad caching policy for expressjs JWT not revoked Mar 1, 2023
@elsapet elsapet merged commit 0d94455 into main Mar 1, 2023
@elsapet elsapet deleted the feat/cwe-525-js-express-jwt branch March 1, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

@vjerci vjerci Awaiting requested review from vjerci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsapet @cfabianski