Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(JS rules): add expressjs rule for missing HTTPS protocol #715

Merged
merged 2 commits into from
Mar 3, 2023
Merged

feat(JS rules): add expressjs rule for missing HTTPS protocol #715

merged 2 commits into from
Mar 3, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Mar 3, 2023

Description

Add rule to trigger in case an app is using http.createServer() and not https.createServer()

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet requested a review from cfabianski March 3, 2023 11:29
@elsapet elsapet merged commit 004d2f9 into main Mar 3, 2023
@elsapet elsapet deleted the feat/add-expressjs-rule-for-missing-https-protocol branch March 3, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotbadger gotbadger gotbadger left review comments

@cfabianski cfabianski cfabianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elsapet @cfabianski @gotbadger