Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up superfluous YAML attributes in rules #741

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix: clean up superfluous YAML attributes in rules #741

merged 1 commit into from
Mar 6, 2023

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Mar 6, 2023 •
edited
Loading

Description

  • Remove superfluous YAML attribute - since trigger is presence, we don't care about data types and we don't care about skipping them either

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet requested a review from gotbadger March 6, 2023 11:51
@gotbadger gotbadger changed the title fix: bad copy pasta fix: Remove superfluous YAML attribute Mar 6, 2023
@elsapet elsapet changed the title fix: Remove superfluous YAML attribute fix: clean up superfluous YAML attributes in rules Mar 6, 2023
@elsapet elsapet merged commit 08f8a15 into main Mar 6, 2023
@elsapet elsapet deleted the fix/bad-copy-pasta branch March 6, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotbadger gotbadger gotbadger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsapet @gotbadger