fix: correct handling of ./ scan target prefix #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsapet
previously approved these changes
Nov 1, 2022
spdawson
force-pushed
the
AMA-3096-fix-handling-of-dot-slash-scan-target-prefix
branch
3 times, most recently
from
35b5f0e
to
0d3ead7
Compare
When the scan target is specified with a `./` prefix, we currently incorrectly build relative file paths within the project directory. Also ensure that we correctly handle the cases where a trailing slash is either present or absent, on a directory path specified as scan target.
spdawson
force-pushed
the
AMA-3096-fix-handling-of-dot-slash-scan-target-prefix
branch
from
0d3ead7
to
d925a35
Compare
elsapet
approved these changes
Nov 1, 2022
spdawson
deleted the
AMA-3096-fix-handling-of-dot-slash-scan-target-prefix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the scan target is specified with a
./prefix, we currently incorrectly build relative file paths within the project directory.Also ensure that we correctly handle the cases where a trailing slash is either present or absent, on a directory path specified as scan target.
Checklist