Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MariaDB June Releases #14

Merged
merged 4 commits into from
Jun 26, 2024
Merged

MariaDB June Releases #14

merged 4 commits into from
Jun 26, 2024

Conversation

jwaisner
Copy link
Contributor

@jwaisner jwaisner commented Jun 26, 2024

User description

10.4.34
10.5.25
10.6.18
10.11.8
11.0.6
11.1.5
11.2.4
11.4.2
11.5.1-RC


PR Type

enhancement, configuration changes


Description

  • Added configuration files for multiple MariaDB versions (10.4.34 to 11.5.1-RC).
  • Defined executable paths, ports, and root user credentials for each version.
  • Added my.ini and backup my.ini configurations for each version.
  • Updated bundle.release date in build.properties to 2024.6.25.
  • Added new MariaDB release versions to releases.properties with corresponding URLs.

Changes walkthrough 📝

Relevant files
Configuration changes
29 files
bearsampp.conf
Add configuration for MariaDB 10.11.8                                       

bin/mariadb10.11.8/bearsampp.conf

  • Added configuration file for MariaDB version 10.11.8.
  • Defined executable paths, port, and root user credentials.
  • +10/-0   
    my.ini
    Add my.ini for MariaDB 10.11.8                                                     

    bin/mariadb10.11.8/my.ini

  • Added my.ini configuration for MariaDB 10.11.8.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 10.11.8                                       

    bin/mariadb10.11.8/my.ini.ber

  • Added backup my.ini configuration for MariaDB 10.11.8.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 10.4.34                                       

    bin/mariadb10.4.34/bearsampp.conf

  • Added configuration file for MariaDB version 10.4.34.
  • Defined executable paths, port, and root user credentials.
  • +10/-0   
    my.ini
    Add my.ini for MariaDB 10.4.34                                                     

    bin/mariadb10.4.34/my.ini

  • Added my.ini configuration for MariaDB 10.4.34.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 10.4.34                                       

    bin/mariadb10.4.34/my.ini.ber

  • Added backup my.ini configuration for MariaDB 10.4.34.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 10.5.25                                       

    bin/mariadb10.5.25/bearsampp.conf

  • Added configuration file for MariaDB version 10.5.25.
  • Defined executable paths, port, and root user credentials.
  • +10/-0   
    my.ini
    Add my.ini for MariaDB 10.5.25                                                     

    bin/mariadb10.5.25/my.ini

  • Added my.ini configuration for MariaDB 10.5.25.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 10.5.25                                       

    bin/mariadb10.5.25/my.ini.ber

  • Added backup my.ini configuration for MariaDB 10.5.25.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 10.6.18                                       

    bin/mariadb10.6.18/bearsampp.conf

  • Added configuration file for MariaDB version 10.6.18.
  • Defined executable paths, port, and root user credentials.
  • +10/-0   
    my.ini
    Add my.ini for MariaDB 10.6.18                                                     

    bin/mariadb10.6.18/my.ini

  • Added my.ini configuration for MariaDB 10.6.18.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 10.6.18                                       

    bin/mariadb10.6.18/my.ini.ber

  • Added backup my.ini configuration for MariaDB 10.6.18.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 11.0.6                                         

    bin/mariadb11.0.6/bearsampp.conf

  • Added configuration file for MariaDB version 11.0.6.
  • Defined executable paths, port, and root user credentials.
  • +10/-0   
    my.ini
    Add my.ini for MariaDB 11.0.6                                                       

    bin/mariadb11.0.6/my.ini

  • Added my.ini configuration for MariaDB 11.0.6.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 11.0.6                                         

    bin/mariadb11.0.6/my.ini.ber

  • Added backup my.ini configuration for MariaDB 11.0.6.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 11.1.5                                         

    bin/mariadb11.1.5/bearsampp.conf

  • Added configuration file for MariaDB version 11.1.5.
  • Defined executable paths, port, and root user credentials.
  • +10/-0   
    my.ini
    Add my.ini for MariaDB 11.1.5                                                       

    bin/mariadb11.1.5/my.ini

  • Added my.ini configuration for MariaDB 11.1.5.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 11.1.5                                         

    bin/mariadb11.1.5/my.ini.ber

  • Added backup my.ini configuration for MariaDB 11.1.5.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 11.2.4                                         

    bin/mariadb11.2.4/bearsampp.conf

  • Added configuration file for MariaDB version 11.2.4.
  • Defined executable paths, port, and root user credentials.
  • +10/-0   
    my.ini
    Add my.ini for MariaDB 11.2.4                                                       

    bin/mariadb11.2.4/my.ini

  • Added my.ini configuration for MariaDB 11.2.4.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 11.2.4                                         

    bin/mariadb11.2.4/my.ini.ber

  • Added backup my.ini configuration for MariaDB 11.2.4.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 11.4.2                                         

    bin/mariadb11.4.2/bearsampp.conf

  • Added configuration file for MariaDB version 11.4.2.
  • Defined executable paths, port, and root user credentials.
  • +10/-0   
    my.ini
    Add my.ini for MariaDB 11.4.2                                                       

    bin/mariadb11.4.2/my.ini

  • Added my.ini configuration for MariaDB 11.4.2.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 11.4.2                                         

    bin/mariadb11.4.2/my.ini.ber

  • Added backup my.ini configuration for MariaDB 11.4.2.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    bearsampp.conf
    Add configuration for MariaDB 11.5.1-RC                                   

    bin/mariadb11.5.1-RC/bearsampp.conf

  • Added configuration file for MariaDB version 11.5.1-RC.
  • Defined executable paths, port, and root user credentials.
  • +10/-0   
    my.ini
    Add my.ini for MariaDB 11.5.1-RC                                                 

    bin/mariadb11.5.1-RC/my.ini

  • Added my.ini configuration for MariaDB 11.5.1-RC.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    my.ini.ber
    Add backup my.ini for MariaDB 11.5.1-RC                                   

    bin/mariadb11.5.1-RC/my.ini.ber

  • Added backup my.ini configuration for MariaDB 11.5.1-RC.
  • Defined client and server settings, including port and socket.
  • +46/-0   
    build.properties
    Update bundle release date                                                             

    build.properties

    • Updated bundle.release date to 2024.6.25.
    +1/-1     
    releases.properties
    Add new MariaDB release versions to releases.properties   

    releases.properties

  • Added new MariaDB release versions to releases.properties.
  • Included URLs for versions 10.4.34, 10.5.25, 10.6.18, 10.11.8, 11.0.6,
    11.1.5, 11.2.4, 11.4.2, 11.5.1-RC.
  • +9/-0     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    jwaisner added 3 commits June 25, 2024 21:46
    …11.5.1rc)
    
    Update `bundle.release` date in `build.properties` to 2024.6.25
    …, 10.5.25, 10.6.18, 10.11.8, 11.0.6, 11.1.5, 11.2.4, 11.4.2, 11.5.1-RC)
    Copy link

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 4
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review Configuration Duplication:
    The PR includes multiple configuration files for different versions of MariaDB that are largely identical. Consider using a template or a script to generate these configurations dynamically to reduce maintenance overhead and potential for errors.
    Hardcoded Paths:
    The configuration files contain hardcoded paths (e.g., ~BEARSAMPP_LIN_PATH~). Ensure these paths are correctly resolved in all environments where the software will run.
    Security Settings:
    The configurations have some security settings commented out (e.g., #innodb_flush_log_at_trx_commit = 1). It's important to clarify whether these settings are intentionally disabled and document the reasons for these choices.

    Copy link

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Security
    Set a strong default password for the root user to enhance security

    Consider setting a strong default password for mariadbRootPwd instead of leaving it empty.
    This will enhance the security of the MariaDB instance.

    bin/mariadb10.6.18/bearsampp.conf [8]

    -mariadbRootPwd = ""
    +mariadbRootPwd = "strong_default_password"
     
    • Apply this suggestion
    Suggestion importance[1-10]: 10

    Why: The suggestion correctly identifies a security vulnerability by leaving the root password empty and proposes a strong default password, which is crucial for database security.

    10
    Set a strong default password for mariadbRootPwd to enhance security

    The mariadbRootPwd is currently set to an empty string. For security reasons, consider
    setting a strong default password or prompting the user to set one during installation.

    bin/mariadb11.5.1-RC/bearsampp.conf [8]

    -mariadbRootPwd = ""
    +mariadbRootPwd = "strong_password_here"
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: Setting a non-empty default password for mariadbRootPwd is crucial for security. The suggestion to prompt the user to set a password during installation or to provide a strong default is highly relevant and improves security significantly.

    9
    Add symbolic-links=0 to prevent security risks

    Add a symbolic-links=0 directive to the [mysqld] section to prevent security risks
    associated with symbolic links.

    bin/mariadb10.4.34/my.ini.ber [21]

     skip-external-locking
    +symbolic-links=0
     
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: This is a valid security improvement suggestion, adding symbolic-links=0 can help mitigate risks associated with symbolic links exploitation.

    8
    Enhancement
    Increase max_allowed_packet size in [mysqld] section for consistency and to handle larger packets

    Consider increasing the max_allowed_packet size to 16M in the [mysqld] section to match
    the [mysqldump] section. This ensures consistency and can help prevent issues with large
    packets.

    bin/mariadb11.1.5/my.ini.ber [9]

    -max_allowed_packet = 1M
    +max_allowed_packet = 16M
     
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: The suggestion correctly identifies a discrepancy between the max_allowed_packet settings in the [mysqld] and [mysqldump] sections, which could lead to issues with large packets. Increasing it to 16M as suggested would ensure consistency and potentially prevent errors during large data dumps.

    8
    Performance
    Increase innodb_log_file_size to 64M to improve performance and reduce log file rotations

    The innodb_log_file_size is set to 5M, which might be too small for larger databases.
    Consider increasing it to 64M to improve performance and reduce the frequency of log file
    rotations.

    bin/mariadb11.2.4/my.ini.ber [26]

    -innodb_log_file_size = 5M
    +innodb_log_file_size = 64M
     
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Increasing the innodb_log_file_size from 5M to 64M could indeed improve performance by reducing the frequency of log rotations, which is beneficial for larger databases. This is a valid performance enhancement suggestion.

    7
    Increase sort_buffer_size to 2M to improve sorting performance for complex queries

    The sort_buffer_size is set to 512K, which might be insufficient for complex queries.
    Consider increasing it to 2M to improve sorting performance.

    bin/mariadb11.4.2/my.ini.ber [12]

    -sort_buffer_size = 512K
    +sort_buffer_size = 2M
     
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion to increase sort_buffer_size from 512K to 2M is appropriate for enhancing performance on complex queries that require more memory for sorting operations. This is a reasonable performance optimization.

    7

    @N6REJ N6REJ merged commit b98f772 into main Jun 26, 2024
    3 checks passed
    @N6REJ N6REJ deleted the june branch June 26, 2024 04:51
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    enhancement ✨ Improve program
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants