Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CI matrix #70

Merged
merged 3 commits into from
May 2, 2024
Merged

update CI matrix #70

merged 3 commits into from
May 2, 2024

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented May 2, 2024

@orbeckst orbeckst requested a review from IAlibay May 2, 2024 07:21
- fix #69
- only test Python 3.10 - 3.12
- manually specify versions of MDAnalysis in the test matrix that do not
  support some of the python versions (see MDAnalysis/cookiecutter-mdakit#110
  for background)
@orbeckst orbeckst force-pushed the update-ci-matrix branch from d48edbb to 4c38b12 Compare May 2, 2024 07:23
@orbeckst orbeckst linked an issue May 2, 2024 that may be closed by this pull request
@orbeckst
Copy link
Member Author

orbeckst commented May 2, 2024

The CI does not seem to start. The matrix only contains 3.10 / latest instead of 3.11 and 3.12 as well as develop.

I checked the gh-ci.yaml in https://rhysd.github.io/actionlint/ and no syntax issues were found.

Something similar seems to be happening in #68 where I see the same checks, which is weird, because this PR should run different checks than the other one.

@orbeckst
Copy link
Member Author

orbeckst commented May 2, 2024

The three checks that I am seeing as not starting are just the required ones that are already listed. The whole gh-ci.yaml is not running (although the docs one is).

image

@IAlibay
Copy link
Collaborator

IAlibay commented May 2, 2024

@orbeckst the CI action was disabled because it's not run in so long. I manually re-enabled it (need to go to actions, click on the relevant action and then there's a pop up box to enable it again).

I'm going to cycle this PR to get CI running again.

@IAlibay IAlibay closed this May 2, 2024
@IAlibay IAlibay reopened this May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (13b7ec5) to head (7da2f83).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files           2        2           
  Lines          59       59           
=======================================
  Hits           58       58           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, could you also update the pyproject.toml to reflect the new python range?

Copy link
Collaborator

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one thing otherwise lgtm!

pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
@IAlibay IAlibay merged commit b57a2b1 into main May 2, 2024
20 checks passed
@IAlibay IAlibay deleted the update-ci-matrix branch May 2, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.9 CI failing due to MDAnalysis develop supporting different py than stable Make python support 3.9+
2 participants