-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update CI matrix #70
update CI matrix #70
Conversation
orbeckst
commented
May 2, 2024
- fix Python 3.9 CI failing due to MDAnalysis develop supporting different py than stable #69
- only test Python 3.10 - 3.12
- manually specify versions of MDAnalysis in the test matrix that do not support some of the python versions (see [CookieCutter CI] Decouple "latest" and "develop" MDAnalysis compatibility checks MDAnalysis/cookiecutter-mdakit#110 for background)
- fix #69 - only test Python 3.10 - 3.12 - manually specify versions of MDAnalysis in the test matrix that do not support some of the python versions (see MDAnalysis/cookiecutter-mdakit#110 for background)
The CI does not seem to start. The matrix only contains 3.10 / latest instead of 3.11 and 3.12 as well as develop. I checked the gh-ci.yaml in https://rhysd.github.io/actionlint/ and no syntax issues were found. Something similar seems to be happening in #68 where I see the same checks, which is weird, because this PR should run different checks than the other one. |
@orbeckst the CI action was disabled because it's not run in so long. I manually re-enabled it (need to go to actions, click on the relevant action and then there's a pop up box to enable it again). I'm going to cycle this PR to get CI running again. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 2 2
Lines 59 59
=======================================
Hits 58 58
Misses 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm, could you also update the pyproject.toml to reflect the new python range?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the one thing otherwise lgtm!
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>