install propkatraj for doc building #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
orbeckst
commented
May 8, 2024
•
orbeckst
commented
- fix Docs no longer deploy properly #66
- install propkatraj package before building docs
- updated docs CI (updated version, make clear that we use conda-forge channel)
- run docs CI on each PR (and deploy on push to main)
orbeckst
commented
May 8, 2024
.github/workflows/docs.yaml
Outdated
Comment on lines
30
to
40
| auto-update-conda: true | ||
| channel-priority: flexible | ||
| channels: conda-forge | ||
| add-pip-as-python-dependency: true | ||
| architecture: x64 | ||
|
|
||
| miniforge-variant: Mambaforge | ||
| use-mamba: true | ||
| channels: conda-forge | ||
|
|
||
| activate-environment: propkatrajdocs | ||
| auto-update-conda: true | ||
| auto-activate-base: false | ||
| show-channel-urls: true |
There was a problem hiding this comment.
Just made it look like the section in gh-ci.yaml
orbeckst
commented
May 8, 2024
| @@ -1,6 +1,6 @@ | |||
| name: propkatrajdocs | |||
| channels: | |||
| - default | |||
There was a problem hiding this comment.
As far as I can tell, default should have been defaults but because the docs.yaml specified channels: conda-forge, we always used conda-forge anyway.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 2 2
Lines 59 59
=======================================
Hits 58 58
Misses 1 1 ☔ View full report in Codecov by Sentry. |
- fix #66 - updated docs CI (updated version, make clear that we use conda-forge channel)
- always run doc build - only deploy on push to main
orbeckst
force-pushed
the
fix-doc-test-deploy
branch
from
afcf9b5 to
44b3c66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.