feat(upgrade): use multiple routes #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oliboy50
reviewed
Aug 3, 2022
raf262
force-pushed
the
feat/filter-multiple-route
branch
4 times, most recently
from
15bd958
to
959ff29
Compare
raf262
force-pushed
the
feat/filter-multiple-route
branch
from
959ff29
to
fb8fc26
Compare
raf262
force-pushed
the
feat/filter-multiple-route
branch
2 times, most recently
from
f06936c
to
5969742
Compare
omansour
reviewed
Aug 4, 2022
Anicky
approved these changes
Aug 8, 2022
raf262
force-pushed
the
feat/filter-multiple-route
branch
from
5969742
to
cfcbce6
Compare
|
I think that we can avoid new major release by allowing the 2 options (route and routes). |
raf262
force-pushed
the
feat/filter-multiple-route
branch
2 times, most recently
from
dda0a7d
to
b7d9f0f
Compare
L-SeeoX
reviewed
Aug 23, 2022
raf262
force-pushed
the
feat/filter-multiple-route
branch
from
b7d9f0f
to
8d166a8
Compare
Fabex
reviewed
Aug 25, 2022
Fabex
reviewed
Aug 25, 2022
Fabex
reviewed
Aug 25, 2022
src/M6Web/Bundle/LogBridgeBundle/Matcher/Dumper/PhpMatcherDumper.php
Outdated
Show resolved
Hide resolved
Fabex
reviewed
Aug 30, 2022
Comment on lines
+77
to
+78
| if (array_key_exists('route', $config) && array_key_exists('routes', $config)) { | ||
| throw new ParseException(sprintf('You can\'t use both "route" and "routes" parameter from filter "%s"', $name)); |
There was a problem hiding this comment.
I was not expected this. instead of create a 2 if condition for route(s) config you can use the xor operator.
so in the first condition you can replace (!array_key_exists('route', $config) && !array_key_exists('routes', $config)) by (!(array_key_exists('route', $config) xor array_key_exists('routes', $config)))
There was a problem hiding this comment.
We saw this together like a family, it's ok to have both if
Fabex
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I want to add multiple route for the same configuration and also exclude a route
How
Edit the configuration and code to use multiple route, no breaking changes