Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): parser could find route and routes in config #72

Merged
merged 1 commit into from
Aug 30, 2022
Merged

fix(parser): parser could find route and routes in config #72

merged 1 commit into from
Aug 30, 2022

Conversation

raf262
Copy link
Contributor

@raf262 raf262 commented Aug 30, 2022

Why

Sometimes the config could find route and routes in array

How

Change the test to throw the exception of both route and routes set

@raf262 raf262 marked this pull request as ready for review August 30, 2022 09:20
@raf262 raf262 requested a review from a team as a code owner August 30, 2022 09:20
@Fabex Fabex merged commit b09bc7b into master Aug 30, 2022
@Fabex Fabex deleted the fix/routes-exception branch August 30, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabex Fabex Fabex approved these changes

@L-SeeoX L-SeeoX Awaiting requested review from L-SeeoX

@nalscher nalscher Awaiting requested review from nalscher

@titoko titoko Awaiting requested review from titoko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raf262 @Fabex