Handle generic classes when generating member injectors #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arctouch-ianribas Thank you for your contribution 🎉 I think it looks good. Could you please rebase your PR onto the main branch? |
Generate correct member injectors for parameterized classes using the general star (`*`) for all type arguments of the target class. Member injectors for non generic/parameterized classes works as before. Fixes BedrockStreaming#29.
arctouch-ianribas
force-pushed
the
member-injector-for-parameterized-classes
branch
from
35518e8
to
2628290
Compare
Rebased. Great to see the update to Kotlin 2.0 and KSP 2. |
outadoc
approved these changes
Aug 22, 2024
|
@arctouch-ianribas Thanks again! |
arctouch-ianribas
deleted the
member-injector-for-parameterized-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate correct member injectors for parameterized classes using the general star (
*) for all type arguments of the target class.Member injectors for non generic/parameterized classes works as before.
Fixes #29.