Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes round ending stats #2590

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Fixes round ending stats #2590

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ee4ece
Fixes round ending stats
covertcorvid Dec 7, 2023
4958766
trying to fix the file labeler???
covertcorvid Dec 7, 2023
535b50e
Revert "trying to fix the file labeler???"
covertcorvid Dec 7, 2023
157350e
Merge remote-tracking branch 'NSV13/master' into bugfix/EndingStats
covertcorvid Dec 9, 2023
662cf4e
updated the comment
covertcorvid Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nsv13/code/controllers/subsystem/map_vote.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@

/* From the feedback table, for any entry with the key 'nsv_endings', get the round ID and extract the type of ending from the JSON data.
This is a text string. Current values (2023/02/17) are "succeeded", "evacuated", and "failed". Call this result "feedback".
(SELECT round_id, CAST(JSON_EXTRACT(JSON, '$.data') AS CHAR) AS ending FROM ss13_feedback WHERE key_name='nsv_endings') AS feedback
(SELECT round_id, CAST(JSON_EXTRACT(JSON, '$.data[0]') AS CHAR) AS ending FROM ss13_feedback WHERE key_name='nsv_endings') AS feedback

Take the round ID and compare it with the data from the round table to get the map name. This gives us one row per round where we
recorded the ending with the map name and the ending type. The ending type string includes quotation marks.
SELECT map_name, feedback.ending FROM ss13_round INNER JOIN [feedback] ON ss13_round.id=feedback.round_id
*/
var/datum/DBQuery/endings_query = SSdbcore.NewQuery("SELECT map_name, feedback.ending FROM [format_table_name("round")] INNER JOIN (" + \
"SELECT round_id, CAST(JSON_EXTRACT(JSON, '$.data') AS CHAR) AS ending FROM [format_table_name("feedback")] WHERE key_name='nsv_endings') AS feedback " + \
"SELECT round_id, CAST(JSON_EXTRACT(JSON, '$.data\[0\]') AS CHAR) AS ending FROM [format_table_name("feedback")] WHERE key_name='nsv_endings') AS feedback " + \
" ON [format_table_name("round")].id=feedback.round_id")

SSdbcore.QuerySelect(stability_query)
Expand Down
Loading