Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null path better #287

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Handle null path better #287

merged 2 commits into from
Feb 14, 2025

Conversation

uuf6429
Copy link
Contributor

@uuf6429 uuf6429 commented Feb 12, 2025

Closes #284.

acoulton
acoulton requested changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@acoulton acoulton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception LGTM, just the docblock comment. Thanks

src/Behat/Gherkin/Node/FeatureNode.php Outdated Show resolved Hide resolved
@uuf6429 uuf6429 requested a review from acoulton February 13, 2025 19:11
acoulton
acoulton approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

carlos-granados
carlos-granados approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@carlos-granados carlos-granados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @uuf6429

@carlos-granados carlos-granados merged commit 2ba6668 into Behat:master Feb 14, 2025
8 checks passed
@uuf6429 uuf6429 deleted the chore/update-null-path-handling branch February 16, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoulton acoulton acoulton approved these changes

@carlos-granados carlos-granados carlos-granados approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symfony deprecation message (copy&paste mistake?)
3 participants
@uuf6429 @acoulton @carlos-granados