Small Fix for Reloading Tree from #61 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fa8a75b.
|
Can I conclude from these PRs that Groot will now work with ROS2? The README still specifically states otherwise. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
@facontidavide Thanks for merging #61 ! I had a little thing to add to this to make it work in more usecases (reconnect while the bt changed in nav2 and other manually testable corner cases).
So for reference I made the first commit identical to the new old PR of the PR..
I then saw the problems why you choose to include #61 manually (file conflicts), so I redid my PR and put it into smaller commits. This way it should be pretty straight forward.
With this now, nav2 is pretty much good to go to use Groot! :)
Ref to nav2-PR: ros-navigation/navigation2#1958