Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#SHA-22: Fix: ESLint React Hook dependency array warnings #37

Merged

Conversation

gaurangrshah
Copy link
Collaborator

https://linear.app/shadcn-extension/issue/SHA-22/fix-eslint-react-hook-dependency-array-warnings

disables the eslint warnings, but there might be some cases where we should've actually added the values to the dependency array

I did some research about this and left it in the linear task:
https://linear.app/shadcn-extension/issue/SHA-22/fix-eslint-react-hook-dependency-array-warnings#comment-26985577

@BelkacemYerfa BelkacemYerfa merged commit c5fd3a2 into BelkacemYerfa:dev Apr 8, 2024
1 check passed
@gaurangrshah gaurangrshah deleted the disable-eslint-hooks-warnings branch April 10, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants